Changeset 56544

Timestamp:

09/07/2023 08:46:53 PM (3 years ago)

Author:

hellofromTonya

Message:

Code Modernization: Use wp_trigger_error() in WP_Text_Diff_Renderer_Table magic methods.

Replaces trigger_error() with wp_trigger_error() in each of the WP_Text_Diff_Renderer_Table magic methods.

[56354] added the dynamic properties deprecation messages to the __get(), __set(), __isset(), __unset() magic methods. Since that commit, wp_trigger_error() was introduced (see [56530]) as a wrapper for trigger_error().

Follow-up to [56354], [56530].

See #58898, #57686.

Location:

trunk

Files:

• src/wp-includes/class-wp-text-diff-renderer-table.php (modified) (4 diffs)
• tests/phpunit/tests/diff/wpTextDiffRendererTable.php (modified) (4 diffs)

trunk/src/wp-includes/class-wp-text-diff-renderer-table.php

@@ -522 +522 @@
                 }
 
-                trigger_error(
+                wp_trigger_error(
+                        __METHOD__,
                         "The property `{$name}` is not declared. Getting a dynamic property is " .
                         'deprecated since version 6.4.0! Instead, declare the property on the class.',
@@ -545 +546 @@
                 }
 
-                trigger_error(
+                wp_trigger_error(
+                        __METHOD__,
                         "The property `{$name}` is not declared. Setting a dynamic property is " .
                         'deprecated since version 6.4.0! Instead, declare the property on the class.',
@@ -566 +568 @@
                 }
 
-                trigger_error(
+                wp_trigger_error(
+                        __METHOD__,
                         "The property `{$name}` is not declared. Checking `isset()` on a dynamic property " .
                         'is deprecated since version 6.4.0! Instead, declare the property on the class.',
@@ -588 +591 @@
                 }
 
-                trigger_error(
+                wp_trigger_error(
+                        __METHOD__,
                         "A property `{$name}` is not declared. Unsetting a dynamic property is " .
                         'deprecated since version 6.4.0! Instead, declare the property on the class.',

trunk/tests/phpunit/tests/diff/wpTextDiffRendererTable.php

@@ -44 +44 @@
                 $this->expectDeprecation();
                 $this->expectDeprecationMessage(
+                        'WP_Text_Diff_Renderer_Table::__get(): ' .
                         'The property `undeclared_property` is not declared. Getting a dynamic property is ' .
                         'deprecated since version 6.4.0! Instead, declare the property on the class.'
@@ -73 +74 @@
                 $this->expectDeprecation();
                 $this->expectDeprecationMessage(
+                        'WP_Text_Diff_Renderer_Table::__set(): ' .
                         'The property `undeclared_property` is not declared. Setting a dynamic property is ' .
                         'deprecated since version 6.4.0! Instead, declare the property on the class.'
@@ -105 +107 @@
                 $this->expectDeprecation();
                 $this->expectDeprecationMessage(
+                        'WP_Text_Diff_Renderer_Table::__isset(): ' .
                         'The property `undeclared_property` is not declared. Checking `isset()` on a dynamic property ' .
                         'is deprecated since version 6.4.0! Instead, declare the property on the class.'
@@ -132 +135 @@
                 $this->expectDeprecation();
                 $this->expectDeprecationMessage(
+                        'WP_Text_Diff_Renderer_Table::__unset(): ' .
                         'A property `undeclared_property` is not declared. Unsetting a dynamic property is ' .
                         'deprecated since version 6.4.0! Instead, declare the property on the class.'