Changeset 56545 for trunk/src/wp-includes/class-wp-theme-json.php

Timestamp:

09/08/2023 12:25:01 AM (23 months ago)

Author:

isabel_brison

Message:

Editor: performance enhancements to class-wp-theme-json.

Removes unnecessary sanitisation of hardcoded strings and avoids looping over style presets without classes or variables.

Props flixos90.
Fixes #59304.

File:

• trunk/src/wp-includes/class-wp-theme-json.php (modified) (4 diffs)

trunk/src/wp-includes/class-wp-theme-json.php

@@ -1314 +1314 @@
                     }
 
-                    $class_name    = sanitize_title( _wp_array_get( $layout_definition, array( 'className' ), false ) );
+                    $class_name    = _wp_array_get( $layout_definition, array( 'className' ), false );
                     $spacing_rules = _wp_array_get( $layout_definition, array( 'spacingStyles' ), array() );
 
@@ -1371 +1371 @@
             $valid_display_modes = array( 'block', 'flex', 'grid' );
             foreach ( $layout_definitions as $layout_definition ) {
-                $class_name       = sanitize_title( _wp_array_get( $layout_definition, array( 'className' ), false ) );
+                $class_name       = _wp_array_get( $layout_definition, array( 'className' ), false );
                 $base_style_rules = _wp_array_get( $layout_definition, array( 'baseStyles' ), array() );
 
@@ -1568 +1568 @@
         $stylesheet = '';
         foreach ( static::PRESETS_METADATA as $preset_metadata ) {
+            if ( empty( $preset_metadata['classes'] ) ) {
+                continue;
+            }
             $slugs = static::get_settings_slugs( $settings, $preset_metadata, $origins );
             foreach ( $preset_metadata['classes'] as $class => $property ) {
@@ -1765 +1768 @@
         $declarations = array();
         foreach ( static::PRESETS_METADATA as $preset_metadata ) {
+            if ( empty( $preset_metadata['css_vars'] ) ) {
+                continue;
+            }
             $values_by_slug = static::get_settings_values_by_slug( $settings, $preset_metadata, $origins );
             foreach ( $values_by_slug as $slug => $value ) {