Changeset 56549 for trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php

Timestamp:

09/09/2023 09:26:01 AM (15 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-privacy-requests-table.php

@@ -240 +240 @@
 
                     if ( $resend && ! is_wp_error( $resend ) ) {
-                        $count++;
+                        ++$count;
                     } else {
-                        $failures++;
+                        ++$failures;
                     }
                 }
@@ -287 +287 @@
 
                     if ( $result && ! is_wp_error( $result ) ) {
-                        $count++;
+                        ++$count;
                     }
                 }
@@ -310 +310 @@
                 foreach ( $request_ids as $request_id ) {
                     if ( wp_delete_post( $request_id, true ) ) {
-                        $count++;
+                        ++$count;
                     } else {
-                        $failures++;
+                        ++$failures;
                     }
                 }