Changeset 56549 for trunk/src/wp-admin/includes/class-wp-site-health.php

Timestamp:

09/09/2023 09:26:01 AM (20 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -382 +382 @@
         // Loop over the available plugins and check their versions and active state.
         foreach ( $plugins as $plugin_path => $plugin ) {
-            $plugins_total++;
+            ++$plugins_total;
 
             if ( is_plugin_active( $plugin_path ) ) {
-                $plugins_active++;
+                ++$plugins_active;
             }
 
             if ( array_key_exists( $plugin_path, $plugin_updates ) ) {
-                $plugins_need_update++;
+                ++$plugins_need_update;
             }
         }
@@ -544 +544 @@
 
         foreach ( $all_themes as $theme_slug => $theme ) {
-            $themes_total++;
+            ++$themes_total;
 
             if ( array_key_exists( $theme_slug, $theme_updates ) ) {
-                $themes_need_updates++;
+                ++$themes_need_updates;
             }
         }
@@ -553 +553 @@
         // If this is a child theme, increase the allowed theme count by one, to account for the parent.
         if ( is_child_theme() ) {
-            $allowed_theme_count++;
+            ++$allowed_theme_count;
         }
 
         // If there's a default theme installed and not in use, we count that as allowed as well.
         if ( $has_default_theme && ! $using_default_theme ) {
-            $allowed_theme_count++;
+            ++$allowed_theme_count;
         }
 
@@ -3294 +3294 @@
         foreach ( $results as $result ) {
             if ( 'critical' === $result['status'] ) {
-                $site_status['critical']++;
+                ++$site_status['critical'];
             } elseif ( 'recommended' === $result['status'] ) {
-                $site_status['recommended']++;
+                ++$site_status['recommended'];
             } else {
-                $site_status['good']++;
+                ++$site_status['good'];
             }
         }