Changeset 56549 for trunk/src/wp-admin/includes/file.php

Timestamp:

09/09/2023 09:26:01 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/src/wp-admin/includes/file.php (modified) (2 diffs)

trunk/src/wp-admin/includes/file.php

@@ -1494 +1494 @@
                 // Ensure only valid-length signatures are considered.
                 if ( SODIUM_CRYPTO_SIGN_BYTES !== strlen( $signature_raw ) ) {
-                        $skipped_signature++;
+                        ++$skipped_signature;
                         continue;
                 }
@@ -1503 +1503 @@
                         // Only pass valid public keys through.
                         if ( SODIUM_CRYPTO_SIGN_PUBLICKEYBYTES !== strlen( $key_raw ) ) {
-                                $skipped_key++;
+                                ++$skipped_key;
                                 continue;
                         }