Changeset 56549 for trunk/src/wp-admin/includes/template.php

Timestamp:

09/09/2023 09:26:01 AM (16 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/src/wp-admin/includes/template.php (modified) (2 diffs)

trunk/src/wp-admin/includes/template.php

@@ -1356 +1356 @@
                     }
 
-                    $i++;
+                    ++$i;
                     // get_hidden_meta_boxes() doesn't apply in the block editor.
                     $hidden_class = ( ! $screen->is_block_editor() && in_array( $box['id'], $hidden, true ) ) ? ' hide-if-js' : '';
@@ -1551 +1551 @@
                     }
 
-                    $i++;
+                    ++$i;
                     $hidden_class = in_array( $box['id'], $hidden, true ) ? 'hide-if-js' : '';