Changeset 56549 for trunk/src/wp-includes/class-wp-walker.php

Timestamp:

09/09/2023 09:26:01 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/src/wp-includes/class-wp-walker.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-walker.php

@@ -326 +326 @@
                         $empty_array = array();
                         foreach ( $elements as $e ) {
-                                $count++;
+                                ++$count;
                                 if ( $count < $start ) {
                                         continue;
@@ -373 +373 @@
 
                 foreach ( $top_level_elements as $e ) {
-                        $count++;
+                        ++$count;
 
                         // For the last page, need to unset earlier children in order to keep track of orphans.
@@ -417 +417 @@
                 foreach ( $elements as $e ) {
                         if ( empty( $e->$parent_field ) ) {
-                                $num++;
+                                ++$num;
                         }
                 }