Changeset 56549 for trunk/src/wp-includes/class-wpdb.php

Timestamp:

09/09/2023 09:26:01 AM (15 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/src/wp-includes/class-wpdb.php (modified) (6 diffs)

trunk/src/wp-includes/class-wpdb.php

@@ -1540 +1540 @@
                 $l = strlen( $s );
                 while ( $k <= $l && '%' === $s[ $l - $k ] ) {
-                    $k++;
+                    ++$k;
                 }
 
@@ -1601 +1601 @@
 
             $key += 3;
-            $arg_id++;
+            ++$arg_id;
         }
 
@@ -1633 +1633 @@
 
                 $key += 3;
-                $arg_id++;
+                ++$arg_id;
             }
 
@@ -2305 +2305 @@
                 while ( $row = mysqli_fetch_object( $this->result ) ) {
                     $this->last_result[ $num_rows ] = $row;
-                    $num_rows++;
+                    ++$num_rows;
                 }
             }
@@ -2335 +2335 @@
         }
 
-        $this->num_queries++;
+        ++$this->num_queries;
 
         if ( defined( 'SAVEQUERIES' ) && SAVEQUERIES ) {
@@ -3879 +3879 @@
                 foreach ( (array) $this->col_info as $col ) {
                     $new_array[ $i ] = $col->{$info_type};
-                    $i++;
+                    ++$i;
                 }
                 return $new_array;