Changeset 56549 for trunk/src/wp-includes/functions.php

Timestamp:

09/09/2023 09:26:01 AM (17 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/src/wp-includes/functions.php (modified) (4 diffs)

trunk/src/wp-includes/functions.php

@@ -2697 +2697 @@
 
                     $number = $new_number;
-                    $i++;
+                    ++$i;
                 }
             }
@@ -2770 +2770 @@
 
                     $number = $new_number;
-                    $i++;
+                    ++$i;
                 }
             }
@@ -7164 +7164 @@
     $caller      = array();
     $check_class = ! is_null( $ignore_class );
-    $skip_frames++; // Skip this function.
+    ++$skip_frames; // Skip this function.
 
     if ( ! isset( $truncate_paths ) ) {
@@ -7175 +7175 @@
     foreach ( $trace as $call ) {
         if ( $skip_frames > 0 ) {
-            $skip_frames--;
+            --$skip_frames;
         } elseif ( isset( $call['class'] ) ) {
             if ( $check_class && $ignore_class === $call['class'] ) {