Changeset 56549 for trunk/src/wp-includes/media.php

Timestamp:

09/09/2023 09:26:01 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/src/wp-includes/media.php (modified) (4 diffs)

trunk/src/wp-includes/media.php

@@ -2553 +2553 @@
 
     static $instance = 0;
-    $instance++;
+    ++$instance;
 
     if ( ! empty( $attr['ids'] ) ) {
@@ -2900 +2900 @@
 
     static $instance = 0;
-    $instance++;
+    ++$instance;
 
     if ( ! empty( $attr['ids'] ) ) {
@@ -3214 +3214 @@
 
     static $instance = 0;
-    $instance++;
+    ++$instance;
 
     /**
@@ -3433 +3433 @@
 
     static $instance = 0;
-    $instance++;
+    ++$instance;
 
     /**