Changeset 56549 for trunk/src/wp-includes/pomo/po.php

Timestamp:

09/09/2023 09:26:01 AM (13 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/src/wp-includes/pomo/po.php (modified) (4 diffs)

trunk/src/wp-includes/pomo/po.php

@@ -343 +343 @@
             $msgstr_index = 0;
             while ( true ) {
-                $lineno++;
+                ++$lineno;
                 $line = PO::read_line( $f );
                 if ( ! $line ) {
@@ -366 +366 @@
                     if ( self::is_final( $context ) ) {
                         PO::read_line( $f, 'put-back' );
-                        $lineno--;
+                        --$lineno;
                         break;
                     }
@@ -378 +378 @@
                     if ( self::is_final( $context ) ) {
                         PO::read_line( $f, 'put-back' );
-                        $lineno--;
+                        --$lineno;
                         break;
                     }
@@ -389 +389 @@
                     if ( self::is_final( $context ) ) {
                         PO::read_line( $f, 'put-back' );
-                        $lineno--;
+                        --$lineno;
                         break;
                     }