Changeset 56549 for trunk/src/wp-includes/user.php

Timestamp:

09/09/2023 09:26:01 AM (17 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/src/wp-includes/user.php (modified) (2 diffs)

trunk/src/wp-includes/user.php

@@ -1317 +1317 @@
             }
             if ( empty( $b_roles ) ) {
-                $avail_roles['none']++;
+                ++$avail_roles['none'];
             }
             foreach ( $b_roles as $b_role => $val ) {
                 if ( isset( $avail_roles[ $b_role ] ) ) {
-                    $avail_roles[ $b_role ]++;
+                    ++$avail_roles[ $b_role ];
                 } else {
                     $avail_roles[ $b_role ] = 1;
@@ -2178 +2178 @@
             $alt_user_nicename   = mb_substr( $user_nicename, 0, $base_length ) . "-$suffix";
             $user_nicename_check = $wpdb->get_var( $wpdb->prepare( "SELECT ID FROM $wpdb->users WHERE user_nicename = %s AND user_login != %s LIMIT 1", $alt_user_nicename, $user_login ) );
-            $suffix++;
+            ++$suffix;
         }
         $user_nicename = $alt_user_nicename;