Changeset 56549 for trunk/tests/phpunit/includes/wp-profiler.php

Timestamp:

09/09/2023 09:26:01 AM (15 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/tests/phpunit/includes/wp-profiler.php (modified) (5 diffs)

trunk/tests/phpunit/includes/wp-profiler.php

@@ -73 +73 @@
         if ( isset( $this->profile[ $name ] ) ) {
             $this->profile[ $name ]['time'] += $time;
-            $this->profile[ $name ]['calls']++;
+            ++$this->profile[ $name ]['calls'];
             $this->profile[ $name ]['cache_cold_hits']    += ( $wp_object_cache->cold_cache_hits - $item['cache_cold_hits'] );
             $this->profile[ $name ]['cache_warm_hits']    += ( $wp_object_cache->warm_cache_hits - $item['cache_warm_hits'] );
@@ -114 +114 @@
             global $wp_actions;
             if ( end( $wp_actions ) === $tag ) {
-                $this->stack[ count( $this->stack ) - 1 ]['actions'][ $tag ]++;
+                ++$this->stack[ count( $this->stack ) - 1 ]['actions'][ $tag ];
             } else {
-                $this->stack[ count( $this->stack ) - 1 ]['filters'][ $tag ]++;
+                ++$this->stack[ count( $this->stack ) - 1 ]['filters'][ $tag ];
             }
         }
@@ -124 +124 @@
     public function log_action( $tag ) {
         if ( $this->stack ) {
-            $this->stack[ count( $this->stack ) - 1 ]['actions'][ $tag ]++;
+            ++$this->stack[ count( $this->stack ) - 1 ]['actions'][ $tag ];
         }
     }
@@ -143 +143 @@
             $sql = preg_replace( '/(WHERE \w+ =) \'\[-\w]+\'/', '$1 \'xxx\'', $sql );
 
-            $out[ $sql ]++;
+            ++$out[ $sql ];
         }
         asort( $out );
@@ -154 +154 @@
         foreach ( $queries as $q ) {
             if ( empty( $q[2] ) ) {
-                $out['unknown']++;
+                ++$out['unknown'];
             } else {
-                $out[ $q[2] ]++;
+                ++$out[ $q[2] ];
             }
         }