Changeset 56549 for trunk/tests/phpunit/tests/comment/metaCache.php

Timestamp:

09/09/2023 09:26:01 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/tests/phpunit/tests/comment/metaCache.php (modified) (4 diffs)

trunk/tests/phpunit/tests/comment/metaCache.php

@@ -244 +244 @@
                 $num_queries = get_num_queries();
                 $this->assertSame( 'bar', get_comment_meta( $comments[0], 'foo', 'bar' ) );
-                $num_queries++;
+                ++$num_queries;
                 $this->assertSame( $num_queries, get_num_queries() );
 
@@ -253 +253 @@
                 // A comment from outside the results will not be primed.
                 $this->assertSame( 'bar', get_comment_meta( $comments[4], 'foo', 'bar' ) );
-                $num_queries++;
+                ++$num_queries;
                 $this->assertSame( $num_queries, get_num_queries() );
         }
@@ -294 +294 @@
                 $num_queries = get_num_queries();
                 $this->assertSame( 'bar', get_comment_meta( $comments[0], 'foo', 'bar' ) );
-                $num_queries++;
+                ++$num_queries;
                 $this->assertSame( $num_queries, get_num_queries() );
 
@@ -303 +303 @@
                 // A comment from outside the results will not be primed.
                 $this->assertSame( 'bar', get_comment_meta( $comments[4], 'foo', 'bar' ) );
-                $num_queries++;
+                ++$num_queries;
                 $this->assertSame( $num_queries, get_num_queries() );
         }