Changeset 56549 for trunk/tests/phpunit/tests/comment/query.php

Timestamp:

09/09/2023 09:26:01 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/tests/phpunit/tests/comment/query.php (modified) (6 diffs)

trunk/tests/phpunit/tests/comment/query.php

@@ -4770 +4770 @@
         );
 
-        $num_queries++;
+        ++$num_queries;
         $this->assertSame( $num_queries, get_num_queries() );
         $this->assertSameSets( array( $c ), $q->comments );
@@ -4806 +4806 @@
         );
 
-        $num_queries++;
+        ++$num_queries;
         $this->assertSame( $num_queries, get_num_queries() );
         $this->assertSameSets( array(), $q->comments );
@@ -4842 +4842 @@
         );
 
-        $num_queries++;
+        ++$num_queries;
         $this->assertSame( $num_queries, get_num_queries() );
         $this->assertSameSets( array(), $q->comments );
@@ -4880 +4880 @@
         );
 
-        $num_queries++;
+        ++$num_queries;
         $this->assertSame( $num_queries, get_num_queries() );
         $this->assertSameSets( array( $c ), $q->comments );
@@ -4916 +4916 @@
         );
 
-        $num_queries++;
+        ++$num_queries;
         $this->assertSame( $num_queries, get_num_queries() );
         $this->assertSameSets( array(), $q->comments );
@@ -4954 +4954 @@
         );
 
-        $num_queries++;
+        ++$num_queries;
         $this->assertSame( $num_queries, get_num_queries() );
         $this->assertSameSets( array( $c ), $q->comments );