Changeset 56549 for trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

Timestamp:

09/09/2023 09:26:01 AM (17 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use pre-increment/decrement for stand-alone statements.

Note: This is enforced by WPCS 3.0.0:

1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.

References:

• ​WordPress PHP Coding Standards: Increment/decrement operators
• ​WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators

Props jrf.
See #59161, #58831.

File:

• trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (3 diffs)

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -1663 +1663 @@
         // 3rd page.
         self::factory()->post->create();
-        $total_posts++;
-        $total_pages++;
+        ++$total_posts;
+        ++$total_pages;
         $request = new WP_REST_Request( 'GET', '/wp/v2/posts' );
         $request->set_param( 'page', 3 );
@@ -2280 +2280 @@
         $filter_count   = 0;
         $filter_content = static function() use ( &$filter_count ) {
-            $filter_count++;
+            ++$filter_count;
             return '<p>Filtered content.</p>';
         };
@@ -2316 +2316 @@
         $filter_count   = 0;
         $filter_content = static function() use ( &$filter_count ) {
-            $filter_count++;
+            ++$filter_count;
             return '<p>Filtered content.</p>';
         };