Changeset 56555 for trunk/src/wp-includes/class-wp-term-query.php

Timestamp:

09/11/2023 11:35:59 AM (20 months ago)

Author:

spacedmonkey

Message:

Taxonomy: Cache term objects in WP_Term_Query if query is filtered.

When utilizing the terms_clauses or get_terms_fields filters within WP_Term_Query and the selected fields are modified, the entire term object is now cached. This adjustment is necessary because filters can broaden the selected fields beyond just the term ID. Fields linked to the term object, such as the count or parent, may undergo modifications when queried. Caching the complete object ensures the accurate storage of these modified fields within the cache.

Props spacedmonkey, tnolte, peterwilsoncc.
Fixes #58116.

File:

• trunk/src/wp-includes/class-wp-term-query.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-term-query.php

@@ -739 +739 @@
         $limits   = isset( $clauses['limits'] ) ? $clauses['limits'] : '';
 
+        $fields_is_filtered = implode( ', ', $selects ) !== $fields;
+
         if ( $where ) {
             $where = "WHERE $where";
@@ -783 +785 @@
             } elseif ( 'count' !== $_fields ) {
                 if ( ( 'all_with_object_id' === $_fields && ! empty( $args['object_ids'] ) )
-                    || ( 'all' === $_fields && $args['pad_counts'] )
+                    || ( 'all' === $_fields && $args['pad_counts'] || $fields_is_filtered )
                 ) {
                     $term_ids = wp_list_pluck( $cache, 'term_id' );
@@ -885 +887 @@
                 $term_cache[]    = $object;
             }
+        } elseif ( $fields_is_filtered ) {
+            $term_cache = $term_objects;
         } else {
             $term_cache = wp_list_pluck( $term_objects, 'term_id' );