Changeset 56556 for trunk/src/wp-content/themes/twentyseventeen/functions.php

Timestamp:

09/12/2023 12:04:15 AM (3 years ago)

Author:

westonruter

Message:

Bundled Themes: Use defer loading strategy for theme scripts.

• Add defer loading strategy for all frontend end-user theme scripts (excluding Customizer preview).
• Move scripts to the head which relate to the initial page viewport to ensure they start loading earlier and execute sooner while still not blocking rendering.
• Update Twenty Twenty's script loader (TwentyTwenty_Script_Loader) to support core's built-in script loading strategies (#12009), while also retaining backwards-compatibility for child themes that may set async and defer script data.
• Update the main script loading strategy in Twenty Twenty from async to defer for better performance on repeat page views, since when an async script is cached it will block rendering.

Props westonruter, flixos90, sabernhardt.
Fixes #59316.

File:

• trunk/src/wp-content/themes/twentyseventeen/functions.php (modified) (3 diffs)

trunk/src/wp-content/themes/twentyseventeen/functions.php

@@ -480 +480 @@
         wp_register_script( 'twentyseventeen-skip-link-focus-fix', get_theme_file_uri( '/assets/js/skip-link-focus-fix.js' ), array(), '20161114', array( 'in_footer' => true ) );
 
-        wp_enqueue_script( 'twentyseventeen-global', get_theme_file_uri( '/assets/js/global.js' ), array( 'jquery' ), '20211130', array( 'in_footer' => true ) );
+        wp_enqueue_script(
+                'twentyseventeen-global',
+                get_theme_file_uri( '/assets/js/global.js' ),
+                array( 'jquery' ),
+                '20211130',
+                array(
+                        'in_footer' => false, // Because involves header.
+                        'strategy'  => 'defer',
+                )
+        );
 
         $twentyseventeen_l10n = array(
@@ -487 +496 @@
 
         if ( has_nav_menu( 'top' ) ) {
-                wp_enqueue_script( 'twentyseventeen-navigation', get_theme_file_uri( '/assets/js/navigation.js' ), array( 'jquery' ), '20210122', array( 'in_footer' => true ) );
+                wp_enqueue_script(
+                        'twentyseventeen-navigation',
+                        get_theme_file_uri( '/assets/js/navigation.js' ),
+                        array( 'jquery' ),
+                        '20210122',
+                        array(
+                                'in_footer' => false, // Because involves header.
+                                'strategy'  => 'defer',
+                        )
+                );
                 $twentyseventeen_l10n['expand']   = __( 'Expand child menu', 'twentyseventeen' );
                 $twentyseventeen_l10n['collapse'] = __( 'Collapse child menu', 'twentyseventeen' );
@@ -500 +518 @@
         wp_localize_script( 'twentyseventeen-global', 'twentyseventeenScreenReaderText', $twentyseventeen_l10n );
 
-        wp_enqueue_script( 'jquery-scrollto', get_theme_file_uri( '/assets/js/jquery.scrollTo.js' ), array( 'jquery' ), '2.1.3', array( 'in_footer' => true ) );
+        wp_enqueue_script(
+                'jquery-scrollto',
+                get_theme_file_uri( '/assets/js/jquery.scrollTo.js' ),
+                array( 'jquery' ),
+                '2.1.3',
+                array(
+                        'in_footer' => true,
+                        'strategy'  => 'defer',
+                )
+        );
 
         if ( is_singular() && comments_open() && get_option( 'thread_comments' ) ) {