Changeset 56573 for trunk/src/wp-admin/nav-menus.php

Timestamp:

09/14/2023 02:13:42 AM (3 years ago)

Author:

joedolson

Message:

Administration: Use wp_admin_notice() for .updated.

Add usages of wp_admin_notice() and wp_get_admin_notice() on .updated in the root level of /wp-admin/. Ongoing task to implement new function across core.

Props costdev, joedolson.
See #57791.

File:

• trunk/src/wp-admin/nav-menus.php (modified) (6 diffs)

trunk/src/wp-admin/nav-menus.php

@@ -282 +282 @@
 
                 if ( is_nav_menu_item( $menu_item_id ) && wp_delete_post( $menu_item_id, true ) ) {
-                        $messages[] = '<div id="message" class="updated notice is-dismissible"><p>' . __( 'The menu item has been successfully deleted.' ) . '</p></div>';
+                        $messages[] = wp_get_admin_notice(
+                                __( 'The menu item has been successfully deleted.' ),
+                                array(
+                                        'id'                 => 'message',
+                                        'additional_classes' => array( 'updated' ),
+                                        'dismissible'        => true,
+                                )
+                        );
                 }
 
@@ -303 +310 @@
 
                 if ( is_wp_error( $deletion ) ) {
-                        $messages[] = '<div id="message" class="error notice is-dismissible"><p>' . $deletion->get_error_message() . '</p></div>';
+                        $messages[] = wp_get_admin_notice(
+                                $deletion->get_error_message(),
+                                array(
+                                        'id'                 => 'message',
+                                        'additional_classes' => array( 'error' ),
+                                        'dismissible'        => true,
+                                )
+                        );
                 } else {
-                        $messages[] = '<div id="message" class="updated notice is-dismissible"><p>' . __( 'The menu has been successfully deleted.' ) . '</p></div>';
+                        $messages[] = wp_get_admin_notice(
+                                __( 'The menu has been successfully deleted.' ),
+                                array(
+                                        'id'                 => 'message',
+                                        'additional_classes' => array( 'updated' ),
+                                        'dismissible'        => true,
+                                )
+                        );
                 }
 
@@ -321 +342 @@
 
                         if ( is_wp_error( $deletion ) ) {
-                                $messages[]     = '<div id="message" class="error notice is-dismissible"><p>' . $deletion->get_error_message() . '</p></div>';
+                                $messages[]     = wp_get_admin_notice(
+                                        $deletion->get_error_message(),
+                                        array(
+                                                'id'                 => 'message',
+                                                'additional_classes' => array( 'error' ),
+                                                'dismissible'        => true,
+                                        )
+                                );
                                 $deletion_error = true;
                         }
@@ -327 +355 @@
 
                 if ( empty( $deletion_error ) ) {
-                        $messages[] = '<div id="message" class="updated notice is-dismissible"><p>' . __( 'Selected menus have been successfully deleted.' ) . '</p></div>';
+                        $messages[] = wp_get_admin_notice(
+                                __( 'Selected menus have been successfully deleted.' ),
+                                array(
+                                        'id'                 => 'message',
+                                        'additional_classes' => array( 'updated' ),
+                                        'dismissible'        => true,
+                                )
+                        );
                 }
 
@@ -432 +467 @@
                                 if ( is_wp_error( $_nav_menu_selected_id ) ) {
                                         $_menu_object = $_nav_menu_selected_id;
-                                        $messages[]   = '<div id="message" class="error notice is-dismissible"><p>' . $_nav_menu_selected_id->get_error_message() . '</p></div>';
+                                        $messages[]   = wp_get_admin_notice(
+                                                $_nav_menu_selected_id->get_error_message(),
+                                                array(
+                                                        'id'                 => 'message',
+                                                        'additional_classes' => array( 'error' ),
+                                                        'dismissible'        => true,
+                                                )
+                                        );
                                 } else {
                                         $_menu_object            = wp_get_nav_menu_object( $_nav_menu_selected_id );
@@ -615 +657 @@
 
 if ( ! current_theme_supports( 'menus' ) && ! $num_locations ) {
-        $messages[] = '<div id="message" class="updated"><p>' . sprintf(
+        $message_no_theme_support = sprintf(
                 /* translators: %s: URL to Widgets screen. */
                 __( 'Your theme does not natively support menus, but you can use them in sidebars by adding a &#8220;Navigation Menu&#8221; widget on the <a href="%s">Widgets</a> screen.' ),
                 admin_url( 'widgets.php' )
-        ) . '</p></div>';
+        );
+        $messages[] = wp_get_admin_notice(
+                $message_no_theme_support,
+                array(
+                        'id'                 => 'message',
+                        'additional_classes' => array( 'updated' ),
+                        'dismissible'        => true,
+                )
+        );
 }