Changeset 56574 for trunk/tests/phpunit/tests/style-engine/wpStyleEngineProcessor.php

Timestamp:

09/14/2023 04:54:22 AM (3 years ago)

Author:

isabel_brison

Message:

Editor: disable default style engine optimisation.

Stops style engine from combining CSS selectors by default so that rule order is preserved.

Props ramonopoly, rajinsharwar, timdix, costdev, audrasjb, SergeyBiryukov, JeffPaul, mukesh27.
Fixes #58811.

File:

• trunk/tests/phpunit/tests/style-engine/wpStyleEngineProcessor.php (modified) (7 diffs)

trunk/tests/phpunit/tests/style-engine/wpStyleEngineProcessor.php

@@ -82 +82 @@
                 $a_wonderful_processor->add_rules( array( $a_wonderful_css_rule, $a_very_wonderful_css_rule, $a_more_wonderful_css_rule ) );
 
-                $expected = '.a-more-wonderful-rule {
+                $expected = '.a-wonderful-rule {
+        color: var(--wonderful-color);
+        background-color: orange;
+}
+.a-very_wonderful-rule {
+        color: var(--wonderful-color);
+        background-color: orange;
+}
+.a-more-wonderful-rule {
         font-family: Wonderful sans;
         font-size: 1em;
-        background-color: orange;
-}
-.a-wonderful-rule,
-.a-very_wonderful-rule {
-        color: var(--wonderful-color);
         background-color: orange;
 }
@@ -185 +188 @@
          * Tests printing out 'unoptimized' CSS, that is, uncombined selectors and duplicate CSS rules.
          *
+         * This is the default.
+         *
+         * @ticket 58811
          * @ticket 56467
          *
@@ -231 +237 @@
          * Tests that 'optimized' CSS is output, that is, that duplicate CSS rules are combined under their corresponding selectors.
          *
-         * @ticket 56467
-         *
-         * @covers ::get_css
-         */
-        public function test_should_optimize_css_output_by_default() {
+         * @ticket 58811
+         * @ticket 56467
+         *
+         * @covers ::get_css
+         */
+        public function test_should_not_optimize_css_output_by_default() {
                 $a_sweet_rule = new WP_Style_Engine_CSS_Rule(
                         '.a-sweet-rule',
@@ -256 +263 @@
 
                 $this->assertSame(
-                        '.a-sweet-rule,#an-even-sweeter-rule > marquee{color:var(--sweet-color);background-color:purple;}',
+                        '.a-sweet-rule{color:var(--sweet-color);background-color:purple;}#an-even-sweeter-rule > marquee{color:var(--sweet-color);background-color:purple;}',
                         $a_sweet_processor->get_css( array( 'prettify' => false ) )
                 );
@@ -262 +269 @@
 
         /**
-         * Tests that incoming CSS rules are merged with existing CSS rules.
-         *
+         * Tests that incoming CSS rules are optimized and merged with existing CSS rules.
+         *
+         * @ticket 58811
          * @ticket 56467
          *
@@ -287 +295 @@
                 $this->assertSame(
                         '.a-lovely-rule,.a-lovelier-rule{border-color:purple;}',
-                        $a_lovely_processor->get_css( array( 'prettify' => false ) ),
+                        $a_lovely_processor->get_css(
+                                array(
+                                        'prettify' => false,
+                                        'optimize' => true,
+                                )
+                        ),
                         'Return value of get_css() does not match expectations when combining 2 CSS rules'
                 );
@@ -309 +322 @@
                 $this->assertSame(
                         '.a-lovely-rule,.a-lovelier-rule,.a-most-lovely-rule,.a-perfectly-lovely-rule{border-color:purple;}',
-                        $a_lovely_processor->get_css( array( 'prettify' => false ) ),
+                        $a_lovely_processor->get_css(
+                                array(
+                                        'prettify' => false,
+                                        'optimize' => true,
+                                )
+                        ),
                         'Return value of get_css() does not match expectations when combining 4 CSS rules'
                 );