Changeset 56582 for branches/6.3/src/wp-admin/includes/class-wp-upgrader.php

Timestamp:

09/14/2023 10:41:24 AM (13 months ago)

Author:

costdev

Message:

Upgrade/Install: Fix broken sprintf() call when deleting a backup.

In WP_Upgrader::delete_temp_backup(), a malformed sprintf() call did not pass the value, triggering a Warning in PHP 7 and a Fatal Error in PHP 8.

This fixes the malformed sprintf() call by correctly passing the value.

Follow-up to [55720].

Props akihiroharai, afragen.
Merges [56550] to the 6.3 branch.
Fixes #59320.

Location:

branches/6.3

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-wp-upgrader.php (modified) (1 diff)

branches/6.3/src/wp-admin/includes/class-wp-upgrader.php

@@ -1207 +1207 @@
                 $errors->add(
                     'temp_backup_delete_failed',
-                    sprintf( $this->strings['temp_backup_delete_failed'] ),
-                    $args['slug']
+                    sprintf( $this->strings['temp_backup_delete_failed'], $args['slug'] )
                 );
                 continue;