Changeset 56586 for trunk/src/wp-admin/includes/class-wp-links-list-table.php

Timestamp:

09/14/2023 12:44:23 PM (21 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Restore more descriptive variable names in a few class methods.

When various methods parameters in child classes were renamed to $item to match the parent class for PHP 8 named parameter support, most of the methods restored the more descriptive, specific name at the beginning for better readability, with several exceptions for methods consisting only of a few lines.

To avoid confusion about why some methods do that and some don't, this commit aims to bring more consistency to the code, specifically in list tables' ::column_default() methods.

Follow-up to [51728], [51737], [51786].

See #58831.

File:

• trunk/src/wp-admin/includes/class-wp-links-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-links-list-table.php

@@ -291 +291 @@
      */
     public function column_default( $item, $column_name ) {
+        // Restores the more descriptive, specific name for use within this method.
+        $link = $item;
+
         /**
          * Fires for each registered custom link column.
@@ -299 +302 @@
          * @param int    $link_id     Link ID.
          */
-        do_action( 'manage_link_custom_column', $column_name, $item->link_id );
+        do_action( 'manage_link_custom_column', $column_name, $link->link_id );
     }
 
@@ -333 +336 @@
 
         // Restores the more descriptive, specific name for use within this method.
-        $link      = $item;
+        $link = $item;
+
         $edit_link = get_edit_bookmark_link( $link );