Make WordPress Core


Ignore:
Timestamp:
09/14/2023 12:44:23 PM (22 months ago)
Author:
SergeyBiryukov
Message:

Coding Standards: Restore more descriptive variable names in a few class methods.

When various methods parameters in child classes were renamed to $item to match the parent class for PHP 8 named parameter support, most of the methods restored the more descriptive, specific name at the beginning for better readability, with several exceptions for methods consisting only of a few lines.

To avoid confusion about why some methods do that and some don't, this commit aims to bring more consistency to the code, specifically in list tables' ::column_default() methods.

Follow-up to [51728], [51737], [51786].

See #58831.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-wp-media-list-table.php

    r56450 r56586  
    881881        }
    882882
     883        // Restores the more descriptive, specific name for use within this method.
     884        $post = $item;
     885
    883886        $att_title = _draft_or_post_title();
    884         $actions   = $this->_get_row_actions(
    885             $item, // WP_Post object for an attachment.
    886             $att_title
    887         );
     887        $actions   = $this->_get_row_actions( $post, $att_title );
    888888
    889889        return $this->row_actions( $actions );
Note: See TracChangeset for help on using the changeset viewer.