Changeset 56586 for trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php

Timestamp:

09/14/2023 12:44:23 PM (21 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Restore more descriptive variable names in a few class methods.

When various methods parameters in child classes were renamed to $item to match the parent class for PHP 8 named parameter support, most of the methods restored the more descriptive, specific name at the beginning for better readability, with several exceptions for methods consisting only of a few lines.

To avoid confusion about why some methods do that and some don't, this commit aims to bring more consistency to the code, specifically in list tables' ::column_default() methods.

Follow-up to [51728], [51737], [51786].

See #58831.

File:

• trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php

@@ -598 +598 @@
      */
     public function column_default( $item, $column_name ) {
+        // Restores the more descriptive, specific name for use within this method.
+        $blog = $item;
+
         /**
          * Fires for each registered custom column in the Sites list table.
@@ -606 +609 @@
          * @param int    $blog_id     The site ID.
          */
-        do_action( 'manage_sites_custom_column', $column_name, $item['blog_id'] );
+        do_action( 'manage_sites_custom_column', $column_name, $blog['blog_id'] );
     }
 
@@ -715 +718 @@
 
         // Restores the more descriptive, specific name for use within this method.
-        $blog     = $item;
+        $blog = $item;
+
         $blogname = untrailingslashit( $blog['domain'] . $blog['path'] );