Changeset 56586 for trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

Timestamp:

09/14/2023 12:44:23 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Restore more descriptive variable names in a few class methods.

When various methods parameters in child classes were renamed to $item to match the parent class for PHP 8 named parameter support, most of the methods restored the more descriptive, specific name at the beginning for better readability, with several exceptions for methods consisting only of a few lines.

To avoid confusion about why some methods do that and some don't, this commit aims to bring more consistency to the code, specifically in list tables' ::column_default() methods.

Follow-up to [51728], [51737], [51786].

See #58831.

File:

• trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -510 +510 @@
         public function column_cb( $item ) {
                 // Restores the more descriptive, specific name for use within this method.
-                $theme       = $item;
+                $theme = $item;
+
                 $checkbox_id = 'checkbox_' . md5( $theme->get( 'Name' ) );
                 ?>
@@ -879 +880 @@
          */
         public function column_default( $item, $column_name ) {
+                // Restores the more descriptive, specific name for use within this method.
+                $theme = $item;
+
+                $stylesheet = $theme->get_stylesheet();
+
                 /**
                  * Fires inside each custom column of the Multisite themes list table.
@@ -888 +894 @@
                  * @param WP_Theme $theme       Current WP_Theme object.
                  */
-                do_action(
-                        'manage_themes_custom_column',
-                        $column_name,
-                        $item->get_stylesheet(), // Directory name of the theme.
-                        $item // Theme object.
-                );
+                do_action( 'manage_themes_custom_column', $column_name, $stylesheet, $theme );
         }