Changeset 56586 for trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php

Timestamp:

09/14/2023 12:44:23 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Restore more descriptive variable names in a few class methods.

When various methods parameters in child classes were renamed to $item to match the parent class for PHP 8 named parameter support, most of the methods restored the more descriptive, specific name at the beginning for better readability, with several exceptions for methods consisting only of a few lines.

To avoid confusion about why some methods do that and some don't, this commit aims to bring more consistency to the code, specifically in list tables' ::column_default() methods.

Follow-up to [51728], [51737], [51786].

See #58831.

File:

• trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php

@@ -459 +459 @@
          */
         public function column_default( $item, $column_name ) {
+                // Restores the more descriptive, specific name for use within this method.
+                $user = $item;
+
                 /** This filter is documented in wp-admin/includes/class-wp-users-list-table.php */
-                echo apply_filters(
-                        'manage_users_custom_column',
-                        '', // Custom column output. Default empty.
-                        $column_name,
-                        $item->ID // User ID.
-                );
+                echo apply_filters( 'manage_users_custom_column', '', $column_name, $user->ID );
         }
 
@@ -520 +518 @@
 
                 // Restores the more descriptive, specific name for use within this method.
-                $user         = $item;
+                $user = $item;
+
                 $super_admins = get_super_admins();
-
-                $actions = array();
+                $actions      = array();
 
                 if ( current_user_can( 'edit_user', $user->ID ) ) {