Changeset 56586 for trunk/src/wp-admin/includes/class-wp-terms-list-table.php

Timestamp:

09/14/2023 12:44:23 PM (22 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Restore more descriptive variable names in a few class methods.

When various methods parameters in child classes were renamed to $item to match the parent class for PHP 8 named parameter support, most of the methods restored the more descriptive, specific name at the beginning for better readability, with several exceptions for methods consisting only of a few lines.

To avoid confusion about why some methods do that and some don't, this commit aims to bring more consistency to the code, specifically in list tables' ::column_default() methods.

Follow-up to [51728], [51737], [51786].

See #58831.

File:

• trunk/src/wp-admin/includes/class-wp-terms-list-table.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-terms-list-table.php

@@ -465 +465 @@
 
         // Restores the more descriptive, specific name for use within this method.
-        $tag      = $item;
+        $tag = $item;
+
         $taxonomy = $this->screen->taxonomy;
         $uri      = wp_doing_ajax() ? wp_get_referer() : $_SERVER['REQUEST_URI'];
@@ -627 +628 @@
      */
     public function column_default( $item, $column_name ) {
+        // Restores the more descriptive, specific name for use within this method.
+        $tag = $item;
+
         /**
          * Filters the displayed columns in the terms list table.
@@ -644 +648 @@
          * @param int    $term_id     Term ID.
          */
-        return apply_filters( "manage_{$this->screen->taxonomy}_custom_column", '', $column_name, $item->term_id );
+        return apply_filters( "manage_{$this->screen->taxonomy}_custom_column", '', $column_name, $tag->term_id );
     }