Changeset 56586 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php

Timestamp:

09/14/2023 12:44:23 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Restore more descriptive variable names in a few class methods.

When various methods parameters in child classes were renamed to $item to match the parent class for PHP 8 named parameter support, most of the methods restored the more descriptive, specific name at the beginning for better readability, with several exceptions for methods consisting only of a few lines.

To avoid confusion about why some methods do that and some don't, this commit aims to bring more consistency to the code, specifically in list tables' ::column_default() methods.

Follow-up to [51728], [51737], [51786].

See #58831.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php

@@ -368 +368 @@
 
                 // Base fields for every post.
+                $fields = $this->get_fields_for_response( $request );
                 $data   = array();
-                $fields = $this->get_fields_for_response( $request );
 
                 if ( rest_is_field_included( 'id', $fields ) ) {
@@ -604 +604 @@
 
                 $theme  = WP_Theme_JSON_Resolver::get_merged_data( 'theme' );
+                $fields = $this->get_fields_for_response( $request );
                 $data   = array();
-                $fields = $this->get_fields_for_response( $request );
 
                 if ( rest_is_field_included( 'settings', $fields ) ) {