Changeset 56586 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-sidebars-controller.php

Timestamp:

09/14/2023 12:44:23 PM (20 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Restore more descriptive variable names in a few class methods.

When various methods parameters in child classes were renamed to $item to match the parent class for PHP 8 named parameter support, most of the methods restored the more descriptive, specific name at the beginning for better readability, with several exceptions for methods consisting only of a few lines.

To avoid confusion about why some methods do that and some don't, this commit aims to bring more consistency to the code, specifically in list tables' ::column_default() methods.

Follow-up to [51728], [51737], [51786].

See #58831.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-sidebars-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-sidebars-controller.php

@@ -321 +321 @@
         // Restores the more descriptive, specific name for use within this method.
         $raw_sidebar = $item;
-        $id          = $raw_sidebar['id'];
-        $sidebar     = array( 'id' => $id );
+
+        $id      = $raw_sidebar['id'];
+        $sidebar = array( 'id' => $id );
 
         if ( isset( $wp_registered_sidebars[ $id ] ) ) {