Changeset 56602

Timestamp:

09/17/2023 10:49:06 PM (9 months ago)

Author:

joedolson

Message:

Administration: Move tabindex="-1" from notice to JS.

In a handful of admin notices, a tabindex attribute is set so that JS can move focus to the notice div. Rather than adding tabindex to globally accepted attributes for wp_kses_post(), move the assignment of tabindex into the JS handlers that display those notices. The attribute is only relevant if JS is running, so there is no reason to add it in the original HTML notice.

Follow up to [56408], [56409], [56410], [56518], [56570], [56571], [56572], [56573], [56576], [56589], [56590], [56597], [56599], [56600], [56601].

Props costdev, joedolson.
See #57791.

Location:

trunk/src

Files:

• js/_enqueues/admin/application-passwords.js (modified) (1 diff)
• js/_enqueues/lib/image-edit.js (modified) (1 diff)
• wp-admin/includes/image-edit.php (modified) (1 diff)
• wp-admin/user-edit.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/application-passwords.js

@@ -61 +61 @@
                 password: response.password
             } ) );
-            $( '.new-application-password-notice' ).trigger( 'focus' );
+            $( '.new-application-password-notice' ).attr( 'tabindex', '-1' ).trigger( 'focus' );
 
             $appPassTbody.prepend( tmplAppPassRow( response ) );

trunk/src/js/_enqueues/lib/image-edit.js

@@ -859 +859 @@
             }
 
-            elementToSetFocusTo.trigger( 'focus' );
+            elementToSetFocusTo.attr( 'tabindex', '-1' ).trigger( 'focus' );
         }, 100 );
     },

trunk/src/wp-admin/includes/image-edit.php

@@ -40 +40 @@
     if ( $msg ) {
         if ( isset( $msg->error ) ) {
-            $note = "<div class='notice notice-error' tabindex='-1' role='alert'><p>$msg->error</p></div>";
+            $note = "<div class='notice notice-error' role='alert'><p>$msg->error</p></div>";
         } elseif ( isset( $msg->msg ) ) {
-            $note = "<div class='notice notice-success' tabindex='-1' role='alert'><p>$msg->msg</p></div>";
+            $note = "<div class='notice notice-success' role='alert'><p>$msg->msg</p></div>";
         }
     }

trunk/src/wp-admin/user-edit.php

@@ -966 +966 @@
 <?php if ( isset( $application_passwords_list_table ) ) : ?>
     <script type="text/html" id="tmpl-new-application-password">
-        <div class="notice notice-success is-dismissible new-application-password-notice" role="alert" tabindex="-1">
+        <div class="notice notice-success is-dismissible new-application-password-notice" role="alert">
             <p class="application-password-display">
                 <label for="new-application-password-value">