Changeset 56605

Timestamp:

09/18/2023 06:47:44 AM (20 months ago)

Author:

isabel_brison

Message:

Editor: add text orientation for blocks with typography support.

Adds a new text orientation option to the typography block support, implemented with CSS writing-mode.

Props poena.
Fixes #59306.

Location:

trunk/src/wp-includes

Files:

• block-supports/typography.php (modified) (5 diffs)
• class-wp-theme-json.php (modified) (5 diffs)
• theme.json (modified) (1 diff)

trunk/src/wp-includes/block-supports/typography.php

@@ -35 +35 @@
     $has_text_decoration_support = _wp_array_get( $typography_supports, array( '__experimentalTextDecoration' ), false );
     $has_text_transform_support  = _wp_array_get( $typography_supports, array( '__experimentalTextTransform' ), false );
+    $has_writing_mode_support    = _wp_array_get( $typography_supports, array( '__experimentalWritingMode' ), false );
 
     $has_typography_support = $has_font_family_support
@@ -44 +45 @@
         || $has_text_columns_support
         || $has_text_decoration_support
-        || $has_text_transform_support;
+        || $has_text_transform_support
+        || $has_writing_mode_support;
 
     if ( ! $block_type->attributes ) {
@@ -106 +108 @@
     $has_text_decoration_support = _wp_array_get( $typography_supports, array( '__experimentalTextDecoration' ), false );
     $has_text_transform_support  = _wp_array_get( $typography_supports, array( '__experimentalTextTransform' ), false );
+    $has_writing_mode_support    = _wp_array_get( $typography_supports, array( '__experimentalWritingMode' ), false );
 
     // Whether to skip individual block support features.
@@ -117 +120 @@
     $should_skip_text_transform  = wp_should_skip_block_supports_serialization( $block_type, 'typography', 'textTransform' );
     $should_skip_letter_spacing  = wp_should_skip_block_supports_serialization( $block_type, 'typography', 'letterSpacing' );
+    $should_skip_writing_mode    = wp_should_skip_block_supports_serialization( $block_type, 'typography', 'writingMode' );
 
     $typography_block_styles = array();
@@ -206 +210 @@
     }
 
+    if ( $has_writing_mode_support &&
+        ! $should_skip_writing_mode &&
+        isset( $block_attributes['style']['typography']['writingMode'] )
+    ) {
+        $typography_block_styles['writingMode'] = _wp_array_get(
+            $block_attributes,
+            array( 'style', 'typography', 'writingMode' ),
+            null
+        );
+    }
+
     $attributes = array();
     $styles     = wp_style_engine_get_styles(

trunk/src/wp-includes/class-wp-theme-json.php

@@ -204 +204 @@
      * @since 6.2.0 Added `outline-*`, and `min-height` properties.
      * @since 6.3.0 Added `column-count` property.
+     * @since 6.4.0 Added `writing-mode` property.
      *
      * @var array
@@ -262 +263 @@
         'filter'                            => array( 'filter', 'duotone' ),
         'box-shadow'                        => array( 'shadow' ),
+        'writing-mode'                      => array( 'typography', 'writingMode' ),
     );
 
@@ -341 +343 @@
      *              `position.fixed` and `position.sticky`.
      * @since 6.3.0 Added support for `typography.textColumns`, removed `layout.definitions`.
-     * @since 6.4.0 Added `layout.allowEditing`.
+     * @since 6.4.0 Added `layout.allowEditing` and `typography.writingMode`.
      *
      * @var array
@@ -410 +412 @@
             'textDecoration' => null,
             'textTransform'  => null,
+            'writingMode'    => null,
         ),
     );
@@ -472 +475 @@
             'textDecoration' => null,
             'textTransform'  => null,
+            'writingMode'    => null,
         ),
         'css'        => null,

trunk/src/wp-includes/theme.json

@@ -264 +264 @@
             "lineHeight": false,
             "textDecoration": true,
-            "textTransform": true
+            "textTransform": true,
+            "writingMode": false
         },
         "blocks": {