Changeset 56609 for trunk/tests/phpunit/tests/hooks/removeAllFilters.php

Timestamp:

09/18/2023 12:39:18 PM (3 years ago)

Author:

spacedmonkey

Message:

Plugins: Store result of call to array_keys, to save repeated calls in WP_Hook class.

In the WP_Hook class the function array_keys was called every time an array of hook priorities was needed. For sites with lots of filters or actions, this would result in thousands of calls to the array_keys function, which uses server resources. Instead of recomputing this array every time it is needed, only compute it when filters are added and removed, then store the result as a class property. Improve unit tests to ensure this behaviour is tested.

Props spacedmonkey, bor0, flixos90, hellofromTonya, mukesh27.
Fixes #58458.

File:

• trunk/tests/phpunit/tests/hooks/removeAllFilters.php (modified) (2 diffs)

trunk/tests/phpunit/tests/hooks/removeAllFilters.php

@@ -19 +19 @@
 
                 $hook->remove_all_filters();
+                $this->check_priority_non_existent( $hook, $priority );
 
                 $this->assertFalse( $hook->has_filters() );
@@ -35 +36 @@
 
                 $hook->remove_all_filters( $priority );
+                $this->check_priority_non_existent( $hook, $priority );
 
                 $this->assertFalse( $hook->has_filter( $hook_name, $callback_one ) );
                 $this->assertTrue( $hook->has_filters() );
                 $this->assertSame( $priority + 1, $hook->has_filter( $hook_name, $callback_two ) );
+                $this->check_priority_exists( $hook, $priority + 1 );
+        }
+
+        protected function check_priority_non_existent( $hook, $priority ) {
+                $priorities = $this->get_priorities( $hook );
+
+                $this->assertNotContains( $priority, $priorities );
+        }
+
+        protected function check_priority_exists( $hook, $priority ) {
+                $priorities = $this->get_priorities( $hook );
+
+                $this->assertContains( $priority, $priorities );
+        }
+        protected function get_priorities( $hook ) {
+                $reflection          = new ReflectionClass( $hook );
+                $reflection_property = $reflection->getProperty( 'priorities' );
+                $reflection_property->setAccessible( true );
+
+                return $reflection_property->getValue( $hook );
         }
 }