Changeset 56631

Timestamp:

09/20/2023 08:08:42 AM (3 years ago)

Author:

audrasjb

Message:

Taxonomy: Restrict term edit link generation in WP_Terms_List_Table::handle_row_actions().

This changeset restricts edit term link generation if the user lacks the edit_term cap in order to prevent PHP 8.1+ deprecations shown when a user lacks this
capability and get_edit_term_link() returns null.

Props thelovekesh, jrf.
Fixes #59336.

Location:

trunk

Files:

• src/wp-admin/includes/class-wp-terms-list-table.php (modified) (2 diffs)
• tests/phpunit/tests/admin/wpTermsListTable.php (added)

trunk/src/wp-admin/includes/class-wp-terms-list-table.php

@@ -475 +475 @@
                 $uri      = wp_doing_ajax() ? wp_get_referer() : $_SERVER['REQUEST_URI'];
 
-                $edit_link = add_query_arg(
-                        'wp_http_referer',
-                        urlencode( wp_unslash( $uri ) ),
-                        get_edit_term_link( $tag, $taxonomy, $this->screen->post_type )
-                );
-
                 $actions = array();
 
@@ -486 +480 @@
                         $actions['edit'] = sprintf(
                                 '<a href="%s" aria-label="%s">%s</a>',
-                                esc_url( $edit_link ),
+                                esc_url(
+                                        add_query_arg(
+                                                'wp_http_referer',
+                                                urlencode( wp_unslash( $uri ) ),
+                                                get_edit_term_link( $tag, $taxonomy, $this->screen->post_type )
+                                        )
+                                ),
                                 /* translators: %s: Taxonomy term name. */
                                 esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $tag->name ) ),