Changeset 56635 for trunk/src/wp-admin/includes/theme.php

Timestamp:

09/20/2023 05:25:26 PM (13 months ago)

Author:

flixos90

Message:

Themes: Deprecate usage of TEMPLATEPATH and STYLESHEETPATH constants.

While generally the functions get_template_directory() and get_stylesheet_directory() were long recommended to use to get the parent or child theme directory, the TEMPLATEPATH and STYLESHEETPATH constants were still used in a few places in core, most importantly in template related logic.

The remaining usage was problematic as it prevented testability of certain key components of WordPress core.

This changeset replaces all remaining usage with the corresponding functions and effectively marks these constants as deprecated. It also adds test coverage accordingly and even unlocks some existing, previously commented out test coverage to work as expected.

Performance of the new approach has been benchmarked and shows no notable differences. Yet, given that the current theme directories are not expected to change within a regular WordPress page load, the get_template_directory() and get_stylesheet_directory() functions were amended with in-memory caching of the result, unless one of the defining values is being filtered.

Props thekt12, spacedmonkey, mukesh27, aaroncampbell, scribu, lloydbudd, cais, chipbennett, toscho, omarabid, CrazyJaco, DrewAPicture, obenland, wonderboymusic, nacin, helen, dd32, chriscct7, SergeyBiryukov, swissspidy, joemcgill, flixos90.
Fixes #18298.

File:

• trunk/src/wp-admin/includes/theme.php (modified) (1 diff)

trunk/src/wp-admin/includes/theme.php

@@ -1167 +1167 @@
      */
     if ( ! empty( $redirect ) ) {
+        $stylesheet_path = get_stylesheet_directory();
+        $template_path   = get_template_directory();
+
         $functions_path = '';
-        if ( str_contains( STYLESHEETPATH, $extension ) ) {
-            $functions_path = STYLESHEETPATH . '/functions.php';
-        } elseif ( str_contains( TEMPLATEPATH, $extension ) ) {
-            $functions_path = TEMPLATEPATH . '/functions.php';
+        if ( str_contains( $stylesheet_path, $extension ) ) {
+            $functions_path = $stylesheet_path . '/functions.php';
+        } elseif ( str_contains( $template_path, $extension ) ) {
+            $functions_path = $template_path . '/functions.php';
         }