Changeset 56659

Timestamp:

09/22/2023 01:55:14 PM (13 months ago)

Author:

desrosj

Message:

Build/Test Tools: Update the environment variable for skipping browser binaries.

This changes the environment variable used in GitHub Action workflows to skip downloading the browser binary that’s a peer dependency when it’s not needed.

In [56647], the version of puppeteer peer-dependency was bumped to >= 20.0.0. Starting in version 20.0.0, puppeteer switched to using Chrome for testing instead of Chromium. With this release, the PUPPETEER_SKIP_CHROMIUM_DOWNLOAD environment variable was removed in favor of the more generic PUPPETEER_SKIP_DOWNLOAD.

All workflows that do not need a browser binary now contain the correct PUPPETEER_SKIP_CHROMIUM_DOWNLOAD variable.

Follow up to [56647].

See #58863.

Location:

trunk/.github/workflows

Files:

• coding-standards.yml (modified) (1 diff)
• phpunit-tests-run.yml (modified) (1 diff)
• test-coverage.yml (modified) (1 diff)
• test-npm.yml (modified) (1 diff)

trunk/.github/workflows/coding-standards.yml

@@ -144 +144 @@
     if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
     env:
-      PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
+      PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
     steps:

trunk/.github/workflows/phpunit-tests-run.yml

@@ -52 +52 @@
   LOCAL_PHP_MEMCACHED: ${{ inputs.memcached }}
   PHPUNIT_CONFIG: ${{ inputs.phpunit-config }}
-  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
 jobs:

trunk/.github/workflows/test-coverage.yml

@@ -30 +30 @@
 
 env:
-  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
   LOCAL_PHP: '7.4-fpm'
   LOCAL_PHP_XDEBUG: true

trunk/.github/workflows/test-npm.yml

@@ -39 +39 @@
 
 env:
-  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
 jobs: