Make WordPress Core


Ignore:
Timestamp:
09/22/2023 02:28:01 PM (7 months ago)
Author:
desrosj
Message:

Build/Test Tools: Simplify some logic in GitHub Action workflows.

This simplifies the logic within the slack-notifications and failed-workflow steps in GitHub Action workflows to use the contains() function and object filtering.

This makes it simpler to perform the needed checks by removing the need to list out every single dependent job defined in needs.

See #58867.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/.github/workflows/performance.yml

    r56537 r56660  
    252252    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    253253    with:
    254       calling_status: ${{ needs.performance.result == 'success' && 'success' || needs.performance.result == 'cancelled' && 'cancelled' || 'failure' }}
     254      calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}
    255255    secrets:
    256256      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     
    271271      github.run_attempt < 2 &&
    272272      (
    273         needs.performance.result == 'cancelled' || needs.performance.result == 'failure'
     273        contains( needs.*.result, 'cancelled' ) ||
     274        contains( needs.*.result, 'failure' )
    274275      )
    275276
Note: See TracChangeset for help on using the changeset viewer.