Changeset 56665 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

09/22/2023 07:56:48 PM (3 years ago)

Author:

joedolson

Message:

Administration: Switch order of label/checkbox in WP_List_Table.

Move the label after the checkbox in WP_List_Table instances. Resolve a false positive that will be presented by automated accessibility testing tools. Follow up to [55954].

Props dimitrism, joedolson, sabernhardt, oglekler, marybaum, tobiasbg.
Fixes #58703.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -1404 +1404 @@
                 if ( ! empty( $columns['cb'] ) ) {
                         static $cb_counter = 1;
-                        $columns['cb']     = '<label class="label-covers-full-cell" for="cb-select-all-' . $cb_counter . '">' .
+                        $columns['cb']     = '<input id="cb-select-all-' . $cb_counter . '" type="checkbox" />
+                        <label for="cb-select-all-' . $cb_counter . '">' .
                                 '<span class="screen-reader-text">' .
                                         /* translators: Hidden accessibility text. */
                                         __( 'Select All' ) .
                                 '</span>' .
-                                '</label>' .
-                                '<input id="cb-select-all-' . $cb_counter . '" type="checkbox" />';
+                                '</label>';
                         ++$cb_counter;
                 }