Changeset 56665 for trunk/src/wp-admin/includes/class-wp-users-list-table.php

Timestamp:

09/22/2023 07:56:48 PM (21 months ago)

Author:

joedolson

Message:

Administration: Switch order of label/checkbox in WP_List_Table.

Move the label after the checkbox in WP_List_Table instances. Resolve a false positive that will be presented by automated accessibility testing tools. Follow up to [55954].

Props dimitrism, joedolson, sabernhardt, oglekler, marybaum, tobiasbg.
Fixes #58703.

File:

• trunk/src/wp-admin/includes/class-wp-users-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-users-list-table.php

@@ -525 +525 @@
             // Set up the checkbox (because the user is editable, otherwise it's empty).
             $checkbox = sprintf(
-                '<label class="label-covers-full-cell" for="user_%1$s"><span class="screen-reader-text">%2$s</span></label>' .
-                '<input type="checkbox" name="users[]" id="user_%1$s" class="%3$s" value="%1$s" />',
+                '<input type="checkbox" name="users[]" id="user_%1$s" class="%2$s" value="%1$s" />' .
+                '<label for="user_%1$s"><span class="screen-reader-text">%3$s</span></label>',
                 $user_object->ID,
+                $role_classes,
                 /* translators: Hidden accessibility text. %s: User login. */
-                sprintf( __( 'Select %s' ), $user_object->user_login ),
-                $role_classes
+                sprintf( __( 'Select %s' ), $user_object->user_login )
             );