Changeset 56665 for trunk/src/wp-admin/update-core.php

Timestamp:

09/22/2023 07:56:48 PM (21 months ago)

Author:

joedolson

Message:

Administration: Switch order of label/checkbox in WP_List_Table.

Move the label after the checkbox in WP_List_Table instances. Resolve a false positive that will be presented by automated accessibility testing tools. Follow up to [55954].

Props dimitrism, joedolson, sabernhardt, oglekler, marybaum, tobiasbg.
Fixes #58703.

File:

• trunk/src/wp-admin/update-core.php (modified) (4 diffs)

trunk/src/wp-admin/update-core.php

@@ -583 +583 @@
         <td class="check-column">
             <?php if ( $compatible_php ) : ?>
-                <label for="<?php echo $checkbox_id; ?>" class="label-covers-full-cell">
+                <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $plugin_file ); ?>" />
+                <label for="<?php echo $checkbox_id; ?>">
                     <span class="screen-reader-text">
                     <?php
@@ -591 +592 @@
                     </span>
                 </label>
-                <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $plugin_file ); ?>" />
             <?php endif; ?>
         </td>
@@ -761 +761 @@
         <td class="check-column">
             <?php if ( $compatible_wp && $compatible_php ) : ?>
-                <label for="<?php echo $checkbox_id; ?>" class="label-covers-full-cell">
+                <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $stylesheet ); ?>" />
+                <label for="<?php echo $checkbox_id; ?>">
                     <span class="screen-reader-text">
                     <?php
@@ -769 +770 @@
                     </span>
                 </label>
-                <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $stylesheet ); ?>" />
             <?php endif; ?>
         </td>