Changeset 56690 for trunk/tests/phpunit/tests/media/wpImageTagAddDecodingAttr.php

Timestamp:

09/25/2023 10:37:00 PM (3 years ago)

Author:

flixos90

Message:

Media: Rely on wp_get_loading_optimization_attributes() to add decoding="async" to images.

The wp_get_loading_optimization_attributes() function was introduced in 6.3, as a single centralized place to control loading optimization attributes for various tags, most importantly images.

This changeset consolidates the decoding="async" optimization, which was added in 6.1, to occur solely as part of wp_get_loading_optimization_attributes(), removing duplicate code and allowing centralized filtering based on [56651].

As part of the change, the wp_img_tag_add_decoding_attr() function has been deprecated. The filter of the same name continues to be maintained for backward compatibility, as before covering only images that are part of a content blob such as post content (the_content).

Props pereirinha, mukesh27, joemcgill, flixos90.
Fixes #58892.
See #53232.

File:

• trunk/tests/phpunit/tests/media/wpImageTagAddDecodingAttr.php (modified) (2 diffs)

trunk/tests/phpunit/tests/media/wpImageTagAddDecodingAttr.php

@@ -20 +20 @@
          * @param string $decoding The value for the 'decoding' attribute. 'no value' for default.
          * @param string $expected The expected `img` tag.
+         *
+         * @expectedDeprecated wp_img_tag_add_decoding_attr
          */
         public function test_should_add_decoding_attr( $image, $context, $decoding, $expected ) {
@@ -81 +83 @@
          * @param mixed  $decoding The value for the 'decoding' attribute. 'no value' for default.
          * @param string $expected The expected `img` tag.
+         *
+         * @expectedDeprecated wp_img_tag_add_decoding_attr
          */
         public function test_should_not_add_decoding_attr( $image, $context, $decoding, $expected ) {