Changeset 56693 for trunk/src/wp-includes/media.php

Timestamp:

09/26/2023 12:11:06 AM (19 months ago)

Author:

flixos90

Message:

Media: Ensure images within shortcodes are correctly considered for loading optimization attributes.

Prior to this change, images added in shortcodes would be considered separately from all other images within post content, which led to incorrect application of the loading optimization attributes loading="lazy" and fetchpriority="high".

This changeset changes the filter priority of wp_filter_content_tags() from the default 10 to 12 on the various content filters it is hooked in, in order to run that function after parsing shortcodes. While this may technically be considered a backward compatibility break, substantial research and lack of any relevant usage led to the assessment that the change is acceptable given its benefits.

An additional related fix included is that now the duplicate processing of images is prevented not only for post content blobs (the_content filter), but also for widget content blobs (widget_text_content and widget_block_content filters).

Props joemcgill, mukesh27, costdev, spacedmonkey, flixos90.
Fixes #58853.

File:

• trunk/src/wp-includes/media.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -5650 +5650 @@
 
     /*
-     * Skip programmatically created images within post content as they need to be handled together with the other
-     * images within the post content.
+     * Skip programmatically created images within content blobs as they need to be handled together with the other
+     * images within the post content or widget content.
      * Without this clause, they would already be considered within their own context which skews the image count and
      * can result in the first post content image being lazy-loaded or an image further down the page being marked as a
      * high priority.
      */
-    // TODO: Handle shortcode images together with the content (see https://core.trac.wordpress.org/ticket/58853).
-    if ( 'the_content' !== $context && 'do_shortcode' !== $context && doing_filter( 'the_content' ) ) {
+    if (
+        'the_content' !== $context && doing_filter( 'the_content' ) ||
+        'widget_text_content' !== $context && doing_filter( 'widget_text_content' ) ||
+        'widget_block_content' !== $context && doing_filter( 'widget_block_content' )
+    ) {
         /** This filter is documented in wp-includes/media.php */
         return apply_filters( 'wp_get_loading_optimization_attributes', $loading_attrs, $tag_name, $attr, $context );
+
     }