Changeset 56701

Timestamp:

09/26/2023 08:07:07 AM (16 months ago)

Author:

gziolo

Message:

Blocks: Add more unit test covering edge cases for Block Hooks

These two new unit tests document how Block Hooks behave with first_child and last_child relative positions. The hooked blocks will only get inserted in the case where the parent block has at least one child block present. While it seems like a limitation, in practice, it's hard to think of a case where the template would use a parent block without its children. It's more likely to happen with patterns in general, but in the case of patterns wired with the block theme, it also seems unlikely. The reasoning here is that out of the box, the block theme should produce a fully functional and valid HTML.

Props ockham.
See #59313.
Follow-up [56649].

File:

• trunk/tests/phpunit/tests/blocks/serialize.php (modified) (1 diff)

trunk/tests/phpunit/tests/blocks/serialize.php

@@ -236 +236 @@
         $this->assertSame( $original, $actual );
     }
+
+    /**
+     * @ticket 59313
+     *
+     * @covers ::traverse_and_serialize_blocks
+     */
+    public function test_traverse_and_serialize_blocks_do_not_insert_in_void_block() {
+        $markup = '<!-- wp:void /-->';
+        $blocks = parse_blocks( $markup );
+
+        $actual = traverse_and_serialize_blocks(
+            $blocks,
+            array( __CLASS__, 'insert_next_to_child_blocks_callback' ),
+            array( __CLASS__, 'insert_next_to_child_blocks_callback' )
+        );
+
+        $this->assertSame( $markup, $actual );
+    }
+
+    /**
+     * @ticket 59313
+     *
+     * @covers ::traverse_and_serialize_blocks
+     */
+    public function test_traverse_and_serialize_blocks_do_not_insert_in_empty_parent_block() {
+        $markup = '<!-- wp:outer --><div class="wp-block-outer"></div><!-- /wp:outer -->';
+        $blocks = parse_blocks( $markup );
+
+        $actual = traverse_and_serialize_blocks(
+            $blocks,
+            array( __CLASS__, 'insert_next_to_child_blocks_callback' ),
+            array( __CLASS__, 'insert_next_to_child_blocks_callback' )
+        );
+
+        $this->assertSame( $markup, $actual );
+    }
 }