Changeset 56709 for trunk/src/wp-includes/block-supports/border.php

Timestamp:

09/26/2023 01:45:23 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Editor: Reduce the use of the _wp_array_get() function to improve performance.

_wp_array_get() is an expensive function, and it's called thousands of times on each page view on the front end. While the function performance was slightly improved in #58376, it is still called more times than it should be.

This commit aims to further optimize its usage:

• In many cases, _wp_array_get() can be replaced with a much simpler and faster isset() check.
• The isset() function is capable of checking nested arrays, so isset( $foo['a']['b']['c'] ) will return false even if $foo['a'] is unset, without throwing any errors or warnings.
• When _wp_array_get() cannot be directly replaced with isset(), it would be good practice to wrap it in an isset() function so that _wp_array_get() only runs when it needs to.

Original PR from Gutenberg repository:

• ​#51116 Performance improvement: Reduce the use of the _wp_array_get() function

Follow-up to [55851], [56382].

Props aristath, jrf, spacedmonkey, mukesh27, swissspidy, hellofromTonya.
Fixes #59405.

File:

• trunk/src/wp-includes/block-supports/border.php (modified) (3 diffs)

trunk/src/wp-includes/block-supports/border.php

@@ -103 +103 @@
         ) {
                 $preset_border_color          = array_key_exists( 'borderColor', $block_attributes ) ? "var:preset|color|{$block_attributes['borderColor']}" : null;
-                $custom_border_color          = _wp_array_get( $block_attributes, array( 'style', 'border', 'color' ), null );
+                $custom_border_color          = isset( $block_attributes['style']['border']['color'] ) ? $block_attributes['style']['border']['color'] : null;
                 $border_block_styles['color'] = $preset_border_color ? $preset_border_color : $custom_border_color;
         }
@@ -110 +110 @@
         if ( $has_border_color_support || $has_border_width_support ) {
                 foreach ( array( 'top', 'right', 'bottom', 'left' ) as $side ) {
-                        $border                       = _wp_array_get( $block_attributes, array( 'style', 'border', $side ), null );
+                        $border                       = isset( $block_attributes['style']['border'][ $side ] ) ? $block_attributes['style']['border'][ $side ] : null;
                         $border_side_values           = array(
                                 'width' => isset( $border['width'] ) && ! wp_should_skip_block_supports_serialization( $block_type, '__experimentalBorder', 'width' ) ? $border['width'] : null,
@@ -153 +153 @@
 function wp_has_border_feature_support( $block_type, $feature, $default_value = false ) {
         // Check if all border support features have been opted into via `"__experimentalBorder": true`.
-        if (
-                property_exists( $block_type, 'supports' ) &&
-                ( true === _wp_array_get( $block_type->supports, array( '__experimentalBorder' ), $default_value ) )
-        ) {
-                return true;
+        if ( property_exists( $block_type, 'supports' ) ) {
+                $block_type_supports_border = isset( $block_type->supports['__experimentalBorder'] )
+                        ? $block_type->supports['__experimentalBorder']
+                        : $default_value;
+                if ( true === $block_type_supports_border ) {
+                        return true;
+                }
         }