Changeset 56709 for trunk/src/wp-includes/block-supports/elements.php

Timestamp:

09/26/2023 01:45:23 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Editor: Reduce the use of the _wp_array_get() function to improve performance.

_wp_array_get() is an expensive function, and it's called thousands of times on each page view on the front end. While the function performance was slightly improved in #58376, it is still called more times than it should be.

This commit aims to further optimize its usage:

• In many cases, _wp_array_get() can be replaced with a much simpler and faster isset() check.
• The isset() function is capable of checking nested arrays, so isset( $foo['a']['b']['c'] ) will return false even if $foo['a'] is unset, without throwing any errors or warnings.
• When _wp_array_get() cannot be directly replaced with isset(), it would be good practice to wrap it in an isset() function so that _wp_array_get() only runs when it needs to.

Original PR from Gutenberg repository:

• ​#51116 Performance improvement: Reduce the use of the _wp_array_get() function

Follow-up to [55851], [56382].

Props aristath, jrf, spacedmonkey, mukesh27, swissspidy, hellofromTonya.
Fixes #59405.

File:

• trunk/src/wp-includes/block-supports/elements.php (modified) (2 diffs)

trunk/src/wp-includes/block-supports/elements.php

@@ -176 +176 @@
         }
 
-        $element_style_object = _wp_array_get( $element_block_styles, array( $element_type ), null );
+        $element_style_object = isset( $element_block_styles[ $element_type ] ) ? $element_block_styles[ $element_type ] : null;
 
         // Process primary element type styles.
@@ -202 +202 @@
         if ( isset( $element_config['elements'] ) ) {
             foreach ( $element_config['elements'] as $element ) {
-                $element_style_object = _wp_array_get( $element_block_styles, array( $element ), null );
+                $element_style_object = isset( $element_block_styles[ $element ] )
+                    ? $element_block_styles[ $element ]
+                    : null;
 
                 if ( $element_style_object ) {