Context Navigation

← Previous Change
Next Change →

position.php

Timestamp:

09/26/2023 01:45:23 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Editor: Reduce the use of the _wp_array_get() function to improve performance.

_wp_array_get() is an expensive function, and it's called thousands of times on each page view on the front end. While the function performance was slightly improved in #58376, it is still called more times than it should be.

This commit aims to further optimize its usage:

In many cases, _wp_array_get() can be replaced with a much simpler and faster isset() check.
The isset() function is capable of checking nested arrays, so isset( $foo['a']['b']['c'] ) will return false even if $foo['a'] is unset, without throwing any errors or warnings.
When _wp_array_get() cannot be directly replaced with isset(), it would be good practice to wrap it in an isset() function so that _wp_array_get() only runs when it needs to.

Original PR from Gutenberg repository:

#51116 Performance improvement: Reduce the use of the _wp_array_get() function

Follow-up to [55851], [56382].

Props aristath, jrf, spacedmonkey, mukesh27, swissspidy, hellofromTonya.
Fixes #59405.

File:

: 1 edited

trunk/src/wp-includes/block-supports/position.php (modified) (3 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-includes/block-supports/position.php

-              r56382
+              r56709
         $global_settings          = wp_get_global_settings();
         $theme_has_sticky_support = _wp_array_get( $global_settings, array( 'position', 'sticky' ), false );
         $theme_has_fixed_support  = _wp_array_get( $global_settings, array( 'position', 'fixed' ), false );
+        $theme_has_sticky_support = isset( $global_settings['position']['sticky'] ) ? $global_settings['position']['sticky'] : false;
+        $theme_has_fixed_support  = isset( $global_settings['position']['fixed'] ) ? $global_settings['position']['fixed'] : false;
         // Only allow output for position types that the theme supports.
 …
+        }
         $style_attribute = _wp_array_get( $block, array( 'attrs', 'style' ), null );
+        $style_attribute = isset( $block['attrs']['style'] ) ? $block['attrs']['style'] : null;
         $class_name      = wp_unique_id( 'wp-container-' );
         $selector        = ".$class_name";
         $position_styles = array();
         $position_type   = _wp_array_get( $style_attribute, array( 'position', 'type' ), '' );
+        $position_type   = isset( $style_attribute['position']['type'] ) ? $style_attribute['position']['type'] : '';
         $wrapper_classes = array();
 …
                 foreach ( $sides as $side ) {
                         $side_value = _wp_array_get( $style_attribute, array( 'position', $side ) );
+                        $side_value = isset( $style_attribute['position'][ $side ] ) ? $style_attribute['position'][ $side ] : null;
                         if ( null !== $side_value ) {
                                 /*

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 56709 for trunk/src/wp-includes/block-supports/position.php

Legend:

trunk/src/wp-includes/block-supports/position.php

Download in other formats: