Changeset 56712

Timestamp:

09/26/2023 03:03:19 PM (3 years ago)

Author:

costdev

Message:

Quick/Bulk Edit: Pre-fill category fields with their status.

This pre-fills category fields in the Quick/Bulk Edit form with their current status.

When bulk editing, if only some of the selected items are in a given category, the category's checkbox will display a line to indicate an indeterminate status.

Props pavelevap, scribu, chasedsiedu, helen, joshcanhelp, ubernaut, Cyberchicken, laumindproductscomau, SergeyBiryukov, Marcoevich, tomybyte, thinkluke, virtality-marketing-solutions, Michalooki, dmsnell, itecrs, pannelars, WHSajid, samba45, Mte90, johnbillion, tomluckies, soulseekah, francina, oglekler, ajmcfadyen, mukesh27, costdev.
Fixes #11302.

Location:

trunk/src

Files:

• js/_enqueues/admin/inline-edit-post.js (modified) (2 diffs)
• wp-admin/css/list-tables.css (modified) (1 diff)
• wp-admin/includes/post.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/inline-edit-post.js

@@ -179 +179 @@
         setBulk : function(){
                 var te = '', type = this.type, c = true;
+                var checkedPosts = $( 'tbody th.check-column input[type="checkbox"]:checked' );
+                var categories = {};
+                var indeterminatePostCategoryField = $( '<input type="hidden" name="indeterminate_post_category[]">' );
                 this.revert();
 
@@ -217 +220 @@
                 // Populate the list of items to bulk edit.
                 $( '#bulk-titles' ).html( '<ul id="bulk-titles-list" role="list">' + te + '</ul>' );
+
+                // Gather up some statistics on which of these checked posts are in which categories.
+                checkedPosts.each( function() {
+                        var id      = $( this ).val();
+                        var checked = $( '#category_' + id ).text().split( ',' );
+
+                        checked.map( function( cid ) {
+                                categories[ cid ] || ( categories[ cid ] = 0 );
+                                // Just record that this category is checked.
+                                categories[ cid ]++;
+                        } );
+                } );
+
+                // Compute initial states.
+                $( '.inline-edit-categories input[name="post_category[]"]' ).each( function() {
+                        // Clear indeterminate states.
+                        $( '<input type="hidden" name="indeterminate_post_category[]">' ).remove();
+
+                        if ( categories[ $( this ).val() ] == checkedPosts.length ) {
+                                // If the number of checked categories matches the number of selected posts, then all posts are in this category.
+                                $( this ).prop( 'checked', true );
+                        } else if ( categories[ $( this ).val() ] > 0 ) {
+                                // If the number is less than the number of selected posts, then it's indeterminate.
+                                $( this ).prop( 'indeterminate', true );
+
+                                // Set indeterminate states for the backend.
+                                indeterminatePostCategoryField.val( $( this ).val() );
+                                $( this ).after( indeterminatePostCategoryField );
+                        }
+                } );
+
+                $( '.inline-edit-categories input[name="post_category[]"]' ).on( 'change', function() {
+                        // Remove the indeterminate flags as there was a specific state change.
+                        $( this ).parent().find( 'input[name="indeterminate_post_category[]"]' ).remove();
+                } );
+
+                $( '.inline-edit-save button' ).on( 'click', function() {
+                        $( '.inline-edit-categories input[name="post_category[]"]' ).prop( 'indeterminate', false );
+                } );
 
                 /**

trunk/src/wp-admin/css/list-tables.css

@@ -1148 +1148 @@
 }
 
+ul.cat-checklist input[name="post_category[]"]:indeterminate::before {
+        content: '';
+        border-top: 2px solid grey;
+        width: 65%;
+        height: 2px;
+        position: absolute;
+        top: calc( 50% + 1px );
+        left: 50%;
+        transform: translate( -50%, -50% );
+}
+
 #bulk-titles .ntdelbutton,
 #bulk-titles .ntdeltitle,

trunk/src/wp-admin/includes/post.php

@@ -642 +642 @@
 
                 if ( isset( $new_cats ) && in_array( 'category', $tax_names, true ) ) {
-                        $cats                       = (array) wp_get_post_categories( $post_id );
-                        $post_data['post_category'] = array_unique( array_merge( $cats, $new_cats ) );
+                        $cats = (array) wp_get_post_categories( $post_id );
+
+                        if (
+                                isset( $post_data['indeterminate_post_category'] )
+                                && is_array( $post_data['indeterminate_post_category'] )
+                        ) {
+                                $indeterminate_post_category = $post_data['indeterminate_post_category'];
+                        } else {
+                                $indeterminate_post_category = array();
+                        }
+
+                        $indeterminate_cats         = array_intersect( $cats, $indeterminate_post_category );
+                        $determinate_cats           = array_diff( $new_cats, $indeterminate_post_category );
+                        $post_data['post_category'] = array_unique( array_merge( $indeterminate_cats, $determinate_cats ) );
+
                         unset( $post_data['tax_input']['category'] );
                 }