Changeset 56714 for trunk/src/wp-admin/includes/post.php

Timestamp:

09/26/2023 03:30:34 PM (18 months ago)

Author:

adamsilverstein

Message:

Revisions: framework for storing post meta revisions.

Enable the storing of post meta in revisions including autosaves and previews:

Add a new argument revisions_enabled to the register_meta function which enables storing meta in revisions.

Add a new wp_post_revision_meta_keys filter which developers can use to control which meta is revisioned - it passes an array of the meta keys with revisions enabled as well as the post type.

Meta keys with revisions enabled are also stored for autosaves, and are restored when a revision or autosave is restored. In addition, meta values are now stored with the autosave revision used for previews. Changes to meta can now be previewed correctly without overwriting the published meta (see #20299) or passing data as a query variable, as the editor currently does to preview changes to the featured image.

Changes to meta with revisions enabled are considered when determining if a new revision should be created. A new revision is created if the meta value has changed since the last revision.

Revisions are now saved on the wp_after_insert_post hook instead of post_updated. The wp_after_insert_post action is fired after post meta has been saved by the REST API which enables attaching meta to the revision. To ensure backwards compatibility with existing action uses, wp_save_post_revision_on_insert function exits early if plugins have removed the previous do_action( 'post_updated', 'wp_save_post_revision' ) call.

Props: alexkingorg, johnbillion, markjaquith, WraithKenny, kovshenin, azaozz, tv-productions, p51labs, mattheu, mikeschroder, Mamaduka, ellatrix, timothyblynjacobs, jakemgold, bookwyrm, ryanduff, mintindeed, wonderboymusic, sanchothefat, westonruter, spacedmonkey, hellofromTonya, drewapicture, adamsilverstein, swisspiddy.
Fixes #20564, #20299.

File:

• trunk/src/wp-admin/includes/post.php (modified) (2 diffs)

trunk/src/wp-admin/includes/post.php

@@ -1971 +1971 @@
          *
          * @since 4.1.0
+         * @since 6.4.0 The `$is_update` parameter was added to indicate if the autosave is being updated or was newly created.
          *
          * @param array $new_autosave Post array - the autosave that is about to be saved.
+         * @param bool  $is_update    Whether this is an existing autosave.
          */
-        do_action( 'wp_creating_autosave', $new_autosave );
-
+        do_action( 'wp_creating_autosave', $new_autosave, true );
         return wp_update_post( $new_autosave );
     }
@@ -1983 +1984 @@
 
     // Otherwise create the new autosave as a special post revision.
-    return _wp_put_post_revision( $post_data, true );
+    $revision = _wp_put_post_revision( $post_data, true );
+
+    if ( ! is_wp_error( $revision ) && 0 !== $revision ) {
+
+        /** This action is documented in wp-admin/includes/post.php */
+        do_action( 'wp_creating_autosave', get_post( $revision, ARRAY_A ), false );
+    }
+
+    return $revision;
+}
+
+/**
+ * Autosave the revisioned meta fields.
+ *
+ * Iterates through the revisioned meta fields and checks each to see if they are set,
+ * and have a changed value. If so, the meta value is saved and attached to the autosave.
+ *
+ * @since 6.4.0
+ *
+ * @param array $new_autosave The new post data being autosaved.
+ */
+function wp_autosave_post_revisioned_meta_fields( $new_autosave ) {
+    /*
+     * The post data arrives as either $_POST['data']['wp_autosave'] or the $_POST
+     * itself. This sets $posted_data to the correct variable.
+     *
+     * Ignoring sanitization to avoid altering meta. Ignoring the nonce check because
+     * this is hooked on inner core hooks where a valid nonce was already checked.
+     *
+     * @phpcs:disable WordPress.Security
+     */
+    $posted_data = isset( $_POST['data']['wp_autosave'] ) ? $_POST['data']['wp_autosave'] : $_POST;
+    // phpcs:enable
+
+    $post_type = get_post_type( $new_autosave['post_parent'] );
+
+    /*
+     * Go thru the revisioned meta keys and save them as part of the autosave, if
+     * the meta key is part of the posted data, the meta value is not blank and
+     * the the meta value has changes from the last autosaved value.
+     */
+    foreach ( wp_post_revision_meta_keys( $post_type ) as $meta_key ) {
+
+        if (
+        isset( $posted_data[ $meta_key ] ) &&
+        get_post_meta( $new_autosave['ID'], $meta_key, true ) !== wp_unslash( $posted_data[ $meta_key ] )
+        ) {
+            /*
+             * Use the underlying delete_metadata() and add_metadata() functions
+             * vs delete_post_meta() and add_post_meta() to make sure we're working
+             * with the actual revision meta.
+             */
+            delete_metadata( 'post', $new_autosave['ID'], $meta_key );
+
+            /*
+             * One last check to ensure meta value not empty().
+             */
+            if ( ! empty( $posted_data[ $meta_key ] ) ) {
+                /*
+                 * Add the revisions meta data to the autosave.
+                 */
+                add_metadata( 'post', $new_autosave['ID'], $meta_key, $posted_data[ $meta_key ] );
+            }
+        }
+    }
 }