Changeset 56714 for trunk/tests/phpunit/tests/meta/registerMeta.php

Timestamp:

09/26/2023 03:30:34 PM (22 months ago)

Author:

adamsilverstein

Message:

Revisions: framework for storing post meta revisions.

Enable the storing of post meta in revisions including autosaves and previews:

Add a new argument revisions_enabled to the register_meta function which enables storing meta in revisions.

Add a new wp_post_revision_meta_keys filter which developers can use to control which meta is revisioned - it passes an array of the meta keys with revisions enabled as well as the post type.

Meta keys with revisions enabled are also stored for autosaves, and are restored when a revision or autosave is restored. In addition, meta values are now stored with the autosave revision used for previews. Changes to meta can now be previewed correctly without overwriting the published meta (see #20299) or passing data as a query variable, as the editor currently does to preview changes to the featured image.

Changes to meta with revisions enabled are considered when determining if a new revision should be created. A new revision is created if the meta value has changed since the last revision.

Revisions are now saved on the wp_after_insert_post hook instead of post_updated. The wp_after_insert_post action is fired after post meta has been saved by the REST API which enables attaching meta to the revision. To ensure backwards compatibility with existing action uses, wp_save_post_revision_on_insert function exits early if plugins have removed the previous do_action( 'post_updated', 'wp_save_post_revision' ) call.

Props: alexkingorg, johnbillion, markjaquith, WraithKenny, kovshenin, azaozz, tv-productions, p51labs, mattheu, mikeschroder, Mamaduka, ellatrix, timothyblynjacobs, jakemgold, bookwyrm, ryanduff, mintindeed, wonderboymusic, sanchothefat, westonruter, spacedmonkey, hellofromTonya, drewapicture, adamsilverstein, swisspiddy.
Fixes #20564, #20299.

File:

• trunk/tests/phpunit/tests/meta/registerMeta.php (modified) (6 diffs)

trunk/tests/phpunit/tests/meta/registerMeta.php

@@ -98 +98 @@
                         'auth_callback'     => '__return_true',
                         'show_in_rest'      => false,
+                        'revisions_enabled' => false,
                     ),
                 ),
@@ -122 +123 @@
                         'auth_callback'     => '__return_true',
                         'show_in_rest'      => false,
+                        'revisions_enabled' => false,
                     ),
                 ),
@@ -176 +178 @@
                         'auth_callback'     => '__return_true',
                         'show_in_rest'      => false,
+                        'revisions_enabled' => false,
                     ),
                 ),
@@ -343 +346 @@
                         'auth_callback'     => '__return_true',
                         'show_in_rest'      => false,
+                        'revisions_enabled' => false,
                     ),
                 ),
@@ -396 +400 @@
                         'auth_callback'     => '__return_true',
                         'show_in_rest'      => false,
+                        'revisions_enabled' => false,
                     ),
                 ),
@@ -1082 +1087 @@
         );
     }
+
+    /**
+     * Test that attempting to register meta with revisions_enabled set to true on a
+     * post type that does not have revisions enabled fails and throws a `doing_it_wrong` notice.
+     *
+     * @ticket 20564
+     */
+    public function test_register_meta_with_revisions_enabled_on_post_type_without_revisions() {
+        $this->setExpectedIncorrectUsage( 'register_meta' );
+
+        // Set up a custom post type with revisions disabled.
+        register_post_type(
+            'test_post_type',
+            array(
+                'supports' => array( 'title', 'editor' ),
+            )
+        );
+
+        $meta_key = 'registered_key1';
+        $args     = array(
+            'revisions_enabled' => true,
+        );
+
+        $register = register_meta(
+            'test_post_type',
+            $meta_key,
+            $args
+        );
+
+        $this->assertFalse( $register );
+    }
 }