Changeset 56724 for trunk/src/wp-includes/block-template-utils.php

Timestamp:

09/26/2023 04:59:11 PM (3 years ago)

Author:

Bernhard Reiter

Message:

Templates: Introduce _remove_theme_attribute_from_template_part_block.

Introduce a _remove_theme_attribute_from_template_part_block() function that can be used as a callback argument for traverse_and_serialize_block(s) on a parsed block tree in order to remove the theme attribute from all Template Part blocks found therein, and deprecate _remove_theme_attribute_in_block_template_content().

Counterpart to _inject_theme_attribute_in_template_part_block from #59338 (which superseded _inject_theme_attribute_in_block_template_content, deprecated in #59452).

Props mukesh27.
Fixes #59460.

File:

• trunk/src/wp-includes/block-template-utils.php (modified) (2 diffs)

trunk/src/wp-includes/block-template-utils.php

@@ -491 +491 @@
 
 /**
- * Parses a block template and removes the theme attribute from each template part.
- *
- * @since 5.9.0
+ * Removes the `theme` attribute from a given template part block.
+ *
+ * @since 6.4.0
  * @access private
  *
- * @param string $template_content Serialized block template content.
- * @return string Updated block template content.
- */
-function _remove_theme_attribute_in_block_template_content( $template_content ) {
-        $has_updated_content = false;
-        $new_content         = '';
-        $template_blocks     = parse_blocks( $template_content );
-
-        $blocks = _flatten_blocks( $template_blocks );
-        foreach ( $blocks as $key => $block ) {
-                if ( 'core/template-part' === $block['blockName'] && isset( $block['attrs']['theme'] ) ) {
-                        unset( $blocks[ $key ]['attrs']['theme'] );
-                        $has_updated_content = true;
-                }
-        }
-
-        if ( ! $has_updated_content ) {
-                return $template_content;
-        }
-
-        foreach ( $template_blocks as $block ) {
-                $new_content .= serialize_block( $block );
-        }
-
-        return $new_content;
+ * @param array $block a parsed block.
+ * @return void
+ */
+function _remove_theme_attribute_from_template_part_block( &$block ) {
+        if (
+                'core/template-part' === $block['blockName'] &&
+                isset( $block['attrs']['theme'] )
+        ) {
+                unset( $block['attrs']['theme'] );
+        }
 }
 
@@ -1279 +1264 @@
         $templates = get_block_templates();
         foreach ( $templates as $template ) {
-                $template->content = _remove_theme_attribute_in_block_template_content( $template->content );
+                $template->content = traverse_and_serialize_blocks(
+                        parse_blocks( $template->content ),
+                        '_remove_theme_attribute_from_template_part_block'
+                );
 
                 $zip->addFromString(