Make WordPress Core

Changeset 56737


Ignore:
Timestamp:
09/27/2023 06:59:01 PM (5 months ago)
Author:
costdev
Message:

Editor: Don't use fluid layout value in typography.

Changes fluid typography calculation to use fallback value if layout wide size is a fluid value.

Props ramonopoly, mukesh27, jastos, aurooba.
Merges [56503] to the 6.3 branch.
Fixes #58754.

Location:
branches/6.3
Files:
4 edited
1 copied

Legend:

Unmodified
Added
Removed
  • branches/6.3

  • branches/6.3/src/wp-includes/block-supports/typography.php

    r55985 r56737  
    518518
    519519    // Defaults.
    520     $default_maximum_viewport_width       = isset( $layout_settings['wideSize'] ) ? $layout_settings['wideSize'] : '1600px';
     520    $default_maximum_viewport_width       = isset( $layout_settings['wideSize'] ) && ! empty( wp_get_typography_value_and_unit( $layout_settings['wideSize'] ) ) ? $layout_settings['wideSize'] : '1600px';
    521521    $default_minimum_viewport_width       = '320px';
    522522    $default_minimum_font_size_factor_max = 0.75;
  • branches/6.3/tests/phpunit/tests/block-supports/typography.php

    r56084 r56737  
    700700                'expected_output' => 'font-size:15px;',
    701701            ),
     702            'returns clamp value using default config if layout is fluid' => array(
     703                'font_size_value' => '15px',
     704                'theme_slug'      => 'block-theme-child-with-fluid-layout',
     705                'expected_output' => 'font-size:clamp(14px, 0.875rem + ((1vw - 3.2px) * 0.078), 15px);',
     706            ),
    702707        );
    703708    }
  • branches/6.3/tests/phpunit/tests/theme/themeDir.php

    r55294 r56737  
    180180            'Block Theme Child Theme',
    181181            'Block Theme Child with no theme.json',
     182            'Block Theme Child Theme With Fluid Layout',
    182183            'Block Theme Child Theme With Fluid Typography',
    183184            'Block Theme Child Theme With Fluid Typography Config',
Note: See TracChangeset for help on using the changeset viewer.